Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] fix: Update text email template #52417

Merged

Conversation

tranvanhieu01012002
Copy link
Contributor

This PR is used to have a good way for multiple languages in email.

I know that all sentences include: punctuation

  return (new MailMessage)
            ->subject(Lang::get('Verify Email Address'))
            ->line(Lang::get('Please click the button below to verify your email address.'))
            ->action(Lang::get('Verify Email Address'), $url)
            ->line(Lang::get('If you did not create an account, no further action is required.'));

So I tried with: "Regards," and it doesn't work.
--> I need to search alot to find the issue -> the email template is: @lang('Regards')
--> I created this PR to hope other developers don't lose time to customizing the language for their emails and Consistency

@lang('Thanks,') not @lang('Thanks'),

@taylorotwell taylorotwell merged commit ef9cf47 into laravel:11.x Aug 7, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants