[11.x] Add MSSQL 2017 and PGSQL 10 builds

[driesvints]

Test the low end supported databases.

Would love to get help getting the tests to pass.

[Jubeki]

It seems like generated columns only exist as of PostegreSQL 12:
https://www.postgresql.org/docs/12/ddl-generated-columns.html

This Documentation (5.3 Generated Columns) does not exist on v11 or v10:
https://www.postgresql.org/docs/10/ddl.html

Edit: Seems to be confirmed by the v12 release notes: https://www.postgresql.org/docs/release/12.0/

[Jubeki]

websearch_to_tsquery exists only as of PostgreSQL v11: https://www.postgresql.org/docs/release/11.0/

[Jubeki]

Primary key and foreign key on partitioned tables only exists as of PostgreSQL v11:
https://www.postgresql.org/docs/release/11.0/

[driesvints]

Thanks @Jubeki. We should be able to skip these tests then somehow.

[Jubeki]

version_compare(Schema::getConnection()->getServerVersion(), '12.0', '<')

This should probably work, as it is also used here:

framework/src/Illuminate/Database/Schema/Grammars/PostgresGrammar.php

Line 126 in 13d2886

.(version_compare($this->connection?->getServerVersion(), '12.0', '<') ? "'' as generated, " : 'a.attgenerated as generated, ')

[driesvints]

Was thinking more like a Phpunit annotation but I guess Phpunit doesn't uses those anymore? 🤔

[Jubeki]

There is already a check for the used type of database, so I don't think there is an Attribute for that:

framework/tests/Integration/Database/SchemaBuilderTest.php

Lines 342 to 344 in 13d2886

	if ($this->driver !== 'pgsql') {
	$this->markTestSkipped('Test requires a PostgreSQL connection.');
	}

[Jubeki]

Maybe @crynobone has an idea about the Attributes.

[crynobone]

You need to write one to hook with Testbench, something like:

<?php

namespace Illuminate\Tests\Testbench\Attributes;

use Attribute;
use Closure;
use Illuminate\Support\Facades\DB;
use Orchestra\Testbench\Contracts\Attributes\Actionable as ActionableContract;

#[Attribute(Attribute::TARGET_CLASS | Attribute::TARGET_METHOD | Attribute::IS_REPEATABLE)]
class RequiresDatabase implements ActionableContract
{
    /**
     * Construct a new attribute.
     *
     * @param  string  $driver
     * @param  string  $versionRequirement
     */
    public function __construct(public string $driver, public string $versionRequirement)
    {
        //
    }

    /**
     * Handle the attribute.
     *
     * @param  \Illuminate\Foundation\Application  $app
     * @param  \Closure(string, array<int, mixed>):void  $action
     * @return void
     */
    public function handle($app, Closure $action): void
    {
        $connection = DB::connection($this->driver);

        if (
            preg_match('/(?P<operator>[<>=!]{0,2})\s*(?P<version>[\d\.-]+(dev|(RC|alpha|beta)[\d\.])?)[ \t]*\r?$/m', $this->versionRequirement, $matches)
        ) {
            if (empty($matches['operator'])) {
                $matches['operator'] = '>=';
            }

            if (! version_compare($connection->getServerVersion(), $matches['version'], $matches['operator'])) {
                call_user_func($action, 'markTestSkipped', [sprintf("Requires %s:%s", $connection->getName(), $this->versionRequirement)]);
            }
        }
    }
}

[driesvints]

It's okay. Fine to leave the current skips. Just need to fix the postgres types failure and then this one is ready to go.

[driesvints]

Nice, thanks @Jubeki