[11.x] Ensure headers are only attached to illuminate responses #52789
+26
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe adding a test, that it also is not attached to RedirectResponse or JsonResponse would also be good. (They both don't extend the illuminate response class, but a Symfony based response class). These both classes don't need any vite assets in my opinion, because they should not render a viewable html response. But if you are talking about an illuminate response, I would assume you are including RedirectResponse and JsonResponse too. |
|
Can this bug fix be ported into 10.x as well? |
|
Can do #53019 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base symfony response does not have the
headermethod. This can cause issues when you are returning a download, which uses theSymfony\Component\HttpFoundation\BinaryFileResponseclass.I think we can safely only attach the Vite headers to Illuminate responses considering this is the first report of the issue.
fixes #52784