[11.x] Fixes trust proxy REMOTE_ADDR
not working in Swoole
#52889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
REMOTE_ADDR
set the trust proxy in Swoole, like this:Is nothing set to
request->trustedProxies
because$_SERVER['REMOTE_ADDR']
does not exist in Swoole. But Laravel internally converts the server information in Swoole into therequest->server
attribute, which includesREMOTE_ADDR
, and thenrequest()->server->get('REMOTE_ADDR')
can get the corresponding value normally.This leads to some logical ambiguity and increases the cognitive burden and learning cost.
So we need to unify the logic to avoid inconsistency. I can't change this in the
Request
class because of the method attribute restrictions, so the solution I've come up with so far is this, it works for me, and I hope there's another better way to solve it.