[11.x] feat: introduce option to change default Number currency #53022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapersoft
reviewed
Oct 3, 2024
Comment on lines
+125
to
+131
| public static function currency(int|float $number, string $in = '', ?string $locale = null) | ||
| { | ||
| static::ensureIntlExtensionIsInstalled(); | ||
|
|
||
| $formatter = new NumberFormatter($locale ?? static::$locale, NumberFormatter::CURRENCY); | ||
|
|
||
| return $formatter->formatCurrency($number, $in); | ||
| return $formatter->formatCurrency($number, ! empty($in) ? $in : static::$currency); |
There was a problem hiding this comment.
I would handle it the same as the $locale-parameter:
public static function currency(int|float $number, ?string $in = null, ?string $locale = null)
{
static::ensureIntlExtensionIsInstalled();
$formatter = new NumberFormatter($locale ?? static::$locale, NumberFormatter::CURRENCY);
return $formatter->formatCurrency($number, $in ?? static::$currency);There was a problem hiding this comment.
I went with ! empty() in case $in was passed as empty :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋,
This PR introduces the functionality to globally change the default currency of the
Numberhelper, much like the locale. Right now the default is passed aa a function argument, however, it can be useful to change the global currency.The use case here is that the default currency is still USD for backwards compatibility with applications, and the
$invariable second arg is still retained.I've introduced a
$currencyvariable, defaulted to US.