[11.x] Fixes validation using shouldConvertToBoolean
when parameter uses dot notation
#53048
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the following validation rules:
The use of
Arr::get()
inshouldConvertToBoolean($parameter)
results in attributes containing dot notation being parsed. Thus, in the above example,Arr::get($this->rules, 'customfield.1', [])
returnsarray
- the second element (zero-indexed) in thecustomfield
validation rules.The intended behaviour is that it returns all of the validation rules for the
customfield.1
attribute.Without the changes in this PR, the test case fails with the below: