[11.x] Fix determining pivot timestamp column name(s) when parent relation missing one or both of timestamps #53103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation missing one or both of timestamps
timacdonald
pushed a commit
to timacdonald/framework
that referenced
this pull request
Oct 15, 2024
…ation missing one or both of timestamps (laravel#53103) Co-authored-by: Sergey Danilchenko <s.danilchenko@ttbooking.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently timestamped pivots try to determine its timestamp column names from its parent relation. But parent model can have its
CREATED_AT/UPDATED_ATcolumns nulled out. This will lead to unexpectednullreturn value fromBelongsToMany::createdAt/updatedAtmethods.This PR adds fallback values (default
created_at/updated_atcolumn names) to fix this issue.