[11.x] Feat: remove HasFactory in model when not required

[MrPunyapal]

A few days ago, I made a PR to improve the make:model command to include the factory generic PHPDoc when needed. Based on comments from @Jubeki and @jasonmccreary, it seems that it would be cool to remove HasFactory if we are not generating a factory at all.

examples:

Command

php artisan make:model Post

Output

<?php

namespace App\Models;

use Illuminate\Database\Eloquent\Model;

class Post extends Model
{
    //
}

Command

php artisan make:model Comment -f

Output

<?php

namespace App\Models;

use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Database\Eloquent\Model;

class Comment extends Model
{
    /** @use HasFactory<\Database\Factories\CommentFactory> */
    use HasFactory;
}

[MrPunyapal]

Something is wrong with failing tests.
Ps. I'm a windows user

[browner12]

how common is it to not have a factory for a model? I don't think I've ever not made one.

[MrPunyapal]

It depends!

Not all developers do write tests.

[browner12]

if "not writing tests" is the reason behind it, maybe we don't want to make it easier on them. lol

[MrPunyapal]

@browner12 Agreed!

Btw main reason behind this PR is these 2 comments!

#52855 (comment)
#52855 (comment)

[crynobone]

I feel fine with these changes as you can still run UserFactory::new() instead of User::factory() all the time.

[crynobone]

Convert to draft as tests are failing on Windows.

[MrPunyapal]

This code does not pass the tests on the local Windows machine. (but in workflow, it passed).

On Windows \r\n is used as a new line and in UNIX \n is used as a new line that's why I used PHP_EOL to specify it and it was passing in the Windows machine.

But as you can see in the failing test in workflow, it is \n instead of \r\n so I doubt if it is running on Windows.

[crynobone]

can you test againts \r\n, \r and \n

[MrPunyapal]

see it passes with \r\n

[MrPunyapal]

@crynobone

I added replacements for both \n and \r\n this way it is passing at both places.

$replacements["{{ factoryImport }}\n"] = '';
$replacements["{{ factoryImport }}\r\n"] = '';

But ideally, it should pass with PHP_EOL so something is wrong with the workflow for sure.

$replacements['{{ factoryImport }}'.PHP_EOL] = '';