Fix for preserveKeys alway being true in LazyCollection::all() #53153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling the all() method in LazyCollection, it always uses
iterator_to_array()
's defaultpreserveKeys=true
.When using
yield from $someArray
in the generator source, with an multiple indexed arrays, this would always overwrite the keys of the previous yielded iteration.This is not always desired behaviour.
This change proposes a non-invasive, backwards compatible fix.
This could however cause confusion because the property is not passed to any
new static
's that are run from within the class. So, when callingdontPreserveKeys()
before e.g.flip()
, the setting is lost.