Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Discard PHP_CLI_SERVER_WORKERS on Windows environment #53178

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

crynobone
Copy link
Member

fixes #53175

CleanShot 2024-10-16 at 07 28 35

PHP_CLI_SERVER_WORKERS is not supported in Windows. However, setting the default to 4 via .env would cause issue on Windows users since the regex used to parse date from server log will become incorrect.

fixes #53175

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone marked this pull request as ready for review October 15, 2024 23:30
@crynobone crynobone mentioned this pull request Oct 15, 2024
@crynobone crynobone changed the title [11.x] Disable PHP_CLI_SERVER_WORKERS on Windows environment [11.x] Discard PHP_CLI_SERVER_WORKERS on Windows environment Oct 15, 2024
@taylorotwell taylorotwell merged commit a13614f into 11.x Oct 16, 2024
34 checks passed
@taylorotwell taylorotwell deleted the windows-compat branch October 16, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ErrorException
2 participants