[11.x] Handle HtmlString constructed with a null #53367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I managed to construct an
HtmlString
with anull
value. I realise that inserting anull
value into anHtmlString
is pretty bad and I should have sanitized the value properly beforehand.However, since this is possible, I believe that the
__toString()
andisEmpty
methods should gracefully handlenull
values. This will prevent a type error exception when getting the string value and correctly reflect that theHtmlString
is empty.