Make the bearerToken method case-insensitive #53627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the bearerToken() method used in the TokenGuard requires the auth-scheme, "Bearer", to be capitalized as it uses the strrpos method to locate the position of the string "Bearer".
While this has been a point of contention and discussion among many groups, the upcoming OAuth 2.1 specification clarifies that the string "Bearer" should be case insensitive.
The fix is simple, replace the use of strrpos with the case insensitive version strripos.
This would allow Laravel to validate both "Bearer" and "bearer" and "bEaReR" for the auth schema as defined in the draft OAuth 2.1 specifications.
More background and discussion can be viewed in this blog article from Auth0/Okta.