Add cache check before registering routes #1367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If routes are already cached, it is not necessary to re-register Horizon routes on every request.
I've found that many Laravel packages don't check for already cached routes and will needlessly re-register routes that already exist in the cache anyway. This reduces boot times in production by ~0.5 ms which adds up when applied to multiple other first-party Laravel packages.
I can open PRs in other projects if this is approved.