Add missing keys that should be cleared when running horizon:clear-metrics
#1482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update enhances the
clear()
method to include additional Redis keys, ensuring that thehorizon:clear-metrics
command comprehensively removes all relevant metrics stored in the cache.Dashboard State Comparison
Before Executing
horizon:clear-metrics
:After Executing
horizon:clear-metrics
(Current Version):After Updating the
clear()
Method:Note on Job Hashes in Cache
Currently,
job hashes
remain in the cache, as illustrated below. Ideally, these should also be cleared. However, removing them without flushing the entire Redis queue connection or using wildcard patterns('*')
is not feasible unless the specific keys to target are known.A potential improvement would be to store job hashes under a specific key, such as
jobs
, to facilitate direct targeting.