Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing keys that should be cleared when running horizon:clear-metrics #1482

Closed
wants to merge 1 commit into from

Conversation

atendwa
Copy link

@atendwa atendwa commented Jul 28, 2024

This update enhances the clear() method to include additional Redis keys, ensuring that the horizon:clear-metrics command comprehensively removes all relevant metrics stored in the cache.

Dashboard State Comparison

  • Before Executing horizon:clear-metrics:
    Screenshot from 2024-07-28 08-37-56

  • After Executing horizon:clear-metrics (Current Version):
    Screenshot from 2024-07-28 08-38-17

  • After Updating the clear() Method:
    Screenshot from 2024-07-28 08-53-01

Note on Job Hashes in Cache

Currently, job hashes remain in the cache, as illustrated below. Ideally, these should also be cleared. However, removing them without flushing the entire Redis queue connection or using wildcard patterns ('*') is not feasible unless the specific keys to target are known.

A potential improvement would be to store job hashes under a specific key, such as jobs, to facilitate direct targeting.

Screenshot from 2024-07-28 09-10-00

Add missing keys that should be cleared when running `horizon:clear-metrics`
@taylorotwell
Copy link
Member

I don't think these keys are meant to be cleared by this command. Metrics is separate from the dashboard.

@atendwa
Copy link
Author

atendwa commented Jul 29, 2024

Is there a command that will achieve this use case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants