Fix error when loading monitoried tags page(#1478) #1485
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue when viewing the show page of a monitored tag
The underlying cause of this error is
MonitoringController::paginate()
was expecting the request, and a$tag
parameter. Since the non-API routes are defined in Vue Router, Laravel is not resolving the{tag}
parameter in the controller with route model binding.In light of that, I added
tag
as a querystring parameter as well so we can grab the value with$request->query('tag')
.I am not sure this is the best way to fix this, but after trying a few different ways, this seemed like the only solution.