Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

[Proposal] Add groupByRaw #1112

Closed
lancepioch opened this issue Apr 10, 2018 · 7 comments · Fixed by laravel/framework#31498
Closed

[Proposal] Add groupByRaw #1112

lancepioch opened this issue Apr 10, 2018 · 7 comments · Fixed by laravel/framework#31498

Comments

@lancepioch
Copy link

We already have the following raw methods:

  • selectRaw
  • whereRaw
  • havingRaw
  • orderByRaw

I'm willing to submit a PR with support.

@dabernathy89
Copy link

I think this is a great idea.

@afbora
Copy link

afbora commented Dec 14, 2018

This's what i'm looking for! 👍

@webbello
Copy link

webbello commented Dec 5, 2019

This will be a great help for developer

@rentalhost
Copy link

@lancepioch do you still intend to do a PR for this case?

@lancepioch
Copy link
Author

@rentalhost yeah I'll see if I can throw out a PR for this tomorrow or next week.

@rentalhost
Copy link

rentalhost commented Feb 16, 2020

@lancepioch I have implemented this feature with two tests (one for the feature itself and another to check if mixed bindings types still works as expected). Do you care if I PR?

You can check here: laravel/framework@d50c82d

@lancepioch
Copy link
Author

If you already got it done, go for it 🥇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants