New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Illuminate\Database\Query\Builder: added support to groupByRaw($sql, array $bindings = []) [fixes #1112]. #31497

Closed

rentalhost wants to merge 3 commits into laravel:master from rentalhost:fixes-1112

Contributor

rentalhost commented Feb 17, 2020 •

edited

Loading

Tests added: 2;
- Test SQL generated for groupByRaw() with bindings;
- Test SQL generated for groupbyRaw() with mixed binding types to ensure that bindings order is respected;
Tested in a real project;
Based at v7.x (master);

Fixes laravel/ideas#1112.


          Illuminate\Database\Query\Builder: added support to groupByRaw($sql, …

bbabf9b

…array $bindings = []) [fixes laravel#1112].

rentalhost force-pushed the fixes-1112 branch from d50c82d to bbabf9b Compare

February 17, 2020 03:53

GrahamCampbell added 2 commits

February 17, 2020 08:51


          Update Builder.php

c836b25


          Update Builder.php

5bcc092

Member

driesvints commented Feb 17, 2020

You don't have to send in this PR twice. Your changes from 6.x will get merged into master.

driesvints closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet