Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

Is there a reason Laravel doesn't provide psr/container-implementation? #2241

Closed
AegirLeet opened this issue May 11, 2020 · 2 comments
Closed

Comments

@AegirLeet
Copy link

AegirLeet commented May 11, 2020

As the title says, is there a specific reason neither illuminate/container nor laravel/framework provide psr/container-implementation in their composer.json, or is this just an oversight?

PSR-11 says:

Packages providing a PSR container implementation should declare that they provide psr/container-implementation 1.0.0.

Projects requiring an implementation should require psr/container-implementation 1.0.0.

Since the container already implements PSR-11, adding this seems like no-brainer to me.

@julienbourdeau
Copy link

Projects requiring an implementation should require psr/container-implementation 1.0.0.

Laravel need illuminate/container, not any container implementation.

Requiring psr/container-implementation is for package which need any PSR-11 container. This is usually for packages for instance.

@AegirLeet
Copy link
Author

AegirLeet commented May 11, 2020

Laravel need illuminate/container, not any container implementation.

I'm talking about the other part of that quote. Laravel should provide psr/container-implementation, not require it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants