Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Provide psr/container-implementation #33020

Merged
merged 2 commits into from
May 30, 2020
Merged

[7.x] Provide psr/container-implementation #33020

merged 2 commits into from
May 30, 2020

Conversation

AegirLeet
Copy link
Contributor

See laravel/ideas#2241.

As recommended in PSR-11, this declares that illuminate/container provides the psr/container-implementation virtual package.

@GrahamCampbell GrahamCampbell marked this pull request as draft May 30, 2020 08:12
@GrahamCampbell
Copy link
Member

This must be added to the root composer.json file too.

@GrahamCampbell GrahamCampbell changed the title Provide psr/container-implementation in illuminate/container [7.x] Provide psr/container-implementation in illuminate/container May 30, 2020
@GrahamCampbell GrahamCampbell changed the title [7.x] Provide psr/container-implementation in illuminate/container [7.x] Provide psr/container-implementation May 30, 2020
@GrahamCampbell GrahamCampbell marked this pull request as ready for review May 30, 2020 08:15
@AegirLeet
Copy link
Contributor Author

Doesn't it propagate because laravel/framework replaces illuminate/container? symfony/symfony doesn't provide it, but it's listed here, so I assumed that's how it works.

@taylorotwell taylorotwell merged commit c29c15b into laravel:7.x May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AegirLeet @GrahamCampbell @taylorotwell