Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] The Laravel Installer requires PHP-7.3 at least #132

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

peter279k
Copy link
Contributor

@peter279k peter279k commented Sep 4, 2020

Changed log

  • According to this line of src/NewCommand class and the line of .github/workflows/tests.yml file, it should let this installer require php-7.3 version at least on composer.json file.

@driesvints
Copy link
Member

Think we can remove the warning then as well.

@peter279k
Copy link
Contributor Author

Think we can remove the warning then as well.

You're right. these following codes can be removed.

        if (version_compare(PHP_VERSION, '7.3.0', '<')) {
            throw new RuntimeException('The Laravel installer requires PHP 7.3.0 or greater. Please use "composer create-project laravel/laravel" instead.');
        }

@driesvints
Copy link
Member

@peter279k can you please add that to the PR?

@peter279k
Copy link
Contributor Author

@peter279k can you please add that to the PR?

Sure. It's removed :).

@driesvints driesvints changed the title The Laravel Installer requires PHP-7.3 at least [4.x] The Laravel Installer requires PHP-7.3 at least Sep 4, 2020
@taylorotwell taylorotwell merged commit 54f3226 into laravel:master Sep 4, 2020
@peter279k peter279k deleted the php7.3_least branch September 4, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants