Fix new command failing without no-ansi option #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for reporting. Saw our scheduled build breaking as well. I suspect this has something to do with the new Symfony 5.3 release. Investigating. |
|
Seems like symfony/symfony#39642 removed the |
|
Released as v4.2.6: https://github.com/laravel/installer/releases/tag/v4.2.6 |
|
@driesvints ah, good finding. Thanks for letting me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
laravel newcommand failing without theno-ansioptionThe underlying Symfony
Input::getOption(source) fails when the option is missing in the command definition, so I think we need to call it after a$input->hasOption()check. Not sure how this has been working before (as it looks like things haven't changed in a while both in Symfony console and here), but it broke today on my end when runninglaravel new ....Running the tests was also failing over here and I enabled the workflows on my fork repository to show it breaking. I was getting the same error locally:
I'm not sure about the other
getOptioncalls in the NewCommand file, though.