Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check directory before deleting in Windows OS #233

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

azizramdan
Copy link
Contributor

@azizramdan azizramdan commented Jul 6, 2022

On Windows OS when using the --force option and the directory does not exist it will throw an error "The system cannot find the file specified.".

This PR ensures the directory exists before deleting.

image

Tested on Windows 10 Pro Version 10.0.19044 Build 19044

@taylorotwell
Copy link
Member

Need someone else on Windows to verify this. Please reactivate when done.

@taylorotwell taylorotwell marked this pull request as draft July 6, 2022 15:49
@creonizer93
Copy link

image

Tested on Windows 11 Pro Version 21H2 Build 22000.739

@azizramdan azizramdan marked this pull request as ready for review July 7, 2022 09:27
@azizramdan
Copy link
Contributor Author

@taylorotwell It has been verified on Windows 10 and 11

@taylorotwell taylorotwell merged commit 9851a81 into laravel:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants