Prevent unresolvable APP_URL
#240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the installer will generate a
*.testhostname that is unresolvable on many machines.If the user has not installed Valet (which doesn't exist for Windows and Linux), then the
*.testhostnames will not resolve unless they have manually set up their DNS to handle it.This PR solves that by testing whether the
*.testhostname resolves before using it, otherwise it leaves theAPP_URLashttp://localhost.This is especially useful with Vite, as we output the
APP_URLto the console to guide users away from visiting the Vite dev server URL directly.