[5.x] Fixes issue if there is no herd or valet installed

[xiCO2k]

This PR fixes the issue #342.

I could not replicate on my machine but based on the error information provided by @Anticom, catching the ProcessStartFailedException it should solve.

Cheers.

[xiCO2k]

@Anticom can you check if this PR solved it?

Thanks.

[Anticom]

@Anticom can you check if this PR solved it?

Thanks.

I'm getting promted for a password now multiple times? Is this normal in 5.x branch of installer?

First was after setting app key:

   INFO  Application key set successfully.

second time after:

   INFO  Application ready in [foo]. You can start your local development using:

All I did to check out your MR was cloning your fork into ~/.composer/vendor/laravel/installer and checking out your branch.

[xiCO2k]

@Anticom can you check if this PR solved it?
Thanks.

I'm getting promted for a password now multiple times? Is this normal in 5.x branch of installer?

First was after setting app key:

   INFO  Application key set successfully.

second time after:

   INFO  Application ready in [foo]. You can start your local development using:

All I did to check out your MR was cloning your fork into ~/.composer/vendor/laravel/installer and checking out your branch.

Nice! the password prompts does not seem related with this.

Thanks for checking it out.

[Anticom]

Yeah I figured it probably has nothing to do with the changes you made to fix the issue. I'll keep you posted once the fix is released.

@xiCO2k
Is there any chance we can get a 5.8.2 today? 🙂

[rjindael]

Would love if this could be pushed to a new version 5.8.2, this currently breaks the Laravel installer entirely on WSL2 :/

[driesvints]

I just published a new release for this one.

[Anticom]

I updated using composer and am still getting promted for password.

[xiCO2k]

Ok but that worked without any error?

[Anticom]

@xiCO2k well if I enter the password correctly, it works as expected w/o any errors.

Maybe @rjindael can dis-/confirm the issue with the password promts?

[rjindael]

@xiCO2k well if I enter the password correctly, it works as expected w/o any errors.

Maybe @rjindael can dis-/confirm the issue with the password promts?

I think my original reply was worded incorrectly , what I had meant was that this PR did solve #342 and that it should be merged as the issue described in #342 currently causes the installer on WSL2 to not work at all

[xiCO2k]

@rjindael can you create an issue with the error you are getting?

Thanks.

[rjindael]

@rjindael can you create an issue with the error you are getting?

Thanks.

Sorry, I think I was not clear, I am not experiencing any issues now, only previously did before this PR was merged. 🙂

[Anticom]

@rjindael So you're not getting promted for passwords during execution of laravel new ... ?

[rjindael]

@rjindael So you're not getting promted for passwords during execution of laravel new ... ?

No