Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Change order of boot and register methods in service providers #4921

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Conversation

SjorsO
Copy link
Contributor

@SjorsO SjorsO commented Jan 29, 2019

This PR changes the order of the boot and register methods in service providers from alphabetic to the order in which they are used by the framework. This small change might make service providers slightly easier to understand, putting the method that runs first at the top, and the method that runs last at the bottom.

If this PR is accepted i'll also create a PR to change the stub used by the artisan make:provider command.

@driesvints driesvints changed the title Change order of boot and register methods in service providers [5.7] Change order of boot and register methods in service providers Jan 29, 2019
@taylorotwell taylorotwell merged commit 4ce439c into laravel:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants