[9.x] The docker-compose.override.yml should not be ignored by default #5838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this file can be used for local overrides, that is not its only intended usage. E.g. a common setup would be like this: - *docker-compose.yml*: services shared across builds - *docker-compose.override.yml*: services only used in development - *docker-compose.production.yml*: configuration needed for building production images. Now for regular development you just need to run `docker-compose up --build` and only in you CI you would build and run for production by explicitly naming the yml files. TL;DR: Excluding docker-compose.override.yml seems to be a personal preference of someone and they should do that in their global .gitignore if the are so inclined.
GrahamCampbell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this file can be used for local overrides, that is not its
only intended usage. E.g. a common setup would be like this:
Now for regular development you just need to run
docker-compose up --buildand onlyin you CI you would build and run for production by explicitly naming the yml files.
TL;DR: Excluding docker-compose.override.yml seems to be a personal preference of
someone and they should do that in their global .gitignore if the are so inclined.