-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Swoole] Send StreamedResponse #151
Conversation
So capture all output? Technically I think that a proper response object is always the way to go, but I understand the appeal of dump(), and it's closer to 'normal' |
So based on the comment, the previous if statement doesn't actually do anything ever. I couldn't really see where the |
(RoadRunner was already working, the PSR-7 factory does something similar, so just added a test) |
I think removing the first statement for stream response is safe. |
Will follow up with this on #153 ... thanks! |
Hey there @barryvdh ,
So, I tried to follow the trails through the issues but couldn't find directions or documentation on stream responses using Octane. Is this generally impossible? If so, that would make a great addition to the documentation, and it's a real headache for our application :( Is there any recommended strategy, any idea? |
Capture the output from a StreamdResponse. Fixes #109
Note that this doesn't actually stream the contents anymore, but it does at least render the output (so after the callback is finished).