Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Fixes server shutting down on concurrently when exceptions are reported at root level of the task #419

Merged

Conversation

nunomaduro
Copy link
Member

This pull request fixes an issue introduced when migrating to https://github.com/laravel/serializable-closure, where errors reported from concurrently ( at the root level of the task ) were causing the server to shutdown.

Fixes #418

@taylorotwell taylorotwell merged commit fd9e996 into 1.x Nov 12, 2021
@taylorotwell taylorotwell deleted the fix/servers-shutting-down-on-concurrent-exceptions branch November 12, 2021 16:51
@foremtehan
Copy link
Contributor

@nunomaduro did you tested it after the PR ? I still get exception and receive the report from Handler

@nunomaduro
Copy link
Member Author

Can you share your "composer.lock" file? @foremtehan

@nunomaduro
Copy link
Member Author

@foremtehan I mean only the contents of the "composer.lock" file please.

@nunomaduro
Copy link
Member Author

Please share the full error you are getting now.

@foremtehan
Copy link
Contributor

foremtehan commented Nov 17, 2021

@nunomaduro
Exception Test#0 [internal function]: App\Http\Controllers\TestController::{closure}()
1 /app/vendor/laravel/serializable-closure/src/Serializers/Signed.php(43): call_user_func_array()
2 [internal function]: Laravel\SerializableClosure\Serializers\Signed->__invoke()
3 /app/vendor/laravel/serializable-closure/src/SerializableClosure.php(48): call_user_func_array()
4 /app/vendor/laravel/octane/src/Worker.php(146): Laravel\SerializableClosure\SerializableClosure->__invoke()
5 /app/vendor/laravel/octane/bin/swoole-server(139): Laravel\Octane\Worker->handleTask()
6 [internal function]: {closure}()
7 /app/vendor/laravel/octane/bin/swoole-server(163): Swoole\Server->start()
8 {main}

@nunomaduro
Copy link
Member Author

Ok - you will need to create an open-source repository, where I can pull, and reproduce your issue. Please open a new ticket for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception cant be caught in concurrently
3 participants