Make the bin files used by Swoole and Roadrunner config options #502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a simple but very helpful change, instead of the bin files used to run the servers being hard coded, they are made configurable.
The reason for doing so is without this developers are forced to extend first the server specific command then the octane:start command if they want to change anything about the boot/worker spawn process.
This is particularly useful for roadrunner if you want to support having roadrunner itself act as a queue consumer as that requires a different setup to PSR7Worker.
The config is defaulted to identical values it had before.
I think the escape hatch it provides is powerful and the increase in maintenance burden is negligible.