Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the bin files used by Swoole and Roadrunner config options #502

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

jedjones-uk
Copy link
Contributor

Hi,

This is a simple but very helpful change, instead of the bin files used to run the servers being hard coded, they are made configurable.

The reason for doing so is without this developers are forced to extend first the server specific command then the octane:start command if they want to change anything about the boot/worker spawn process.

This is particularly useful for roadrunner if you want to support having roadrunner itself act as a queue consumer as that requires a different setup to PSR7Worker.

The config is defaulted to identical values it had before.

I think the escape hatch it provides is powerful and the increase in maintenance burden is negligible.

@taylorotwell
Copy link
Member

Why is one of them {driver}.command and the other is {driver}.server.command?

@jedjones-uk
Copy link
Contributor Author

I went back and forth over using something like {driver}.bin/{driver}.command but ultimately decided to match the roadrunner option to the path it uses to override the config with cli properties.

It didn't look like Swoole had a similar functionality hence just going with root array.

I'm not married to the choice either way, just went with what made sense at the time.

@taylorotwell taylorotwell merged commit a6ac540 into laravel:1.x Apr 8, 2022
@taylorotwell
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants