Re-do: Configurable Roadrunner log level #604
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #601. This adds a new flag,
--log-level
, to theoctane:roadrunner
command.Was asked to provide an explanation as to why this broke; it was, simply put, due to an operator precedence issue added in the second commit.
Will result in
logs.level=
(no actual level) if no--log-level
option is given instead of falling back to the old behaviour, due to.
having higher precedence than?:
.Adding parentheses fixes this:
It's perhaps easiest to see with a simpler example:
Results in
foo
, whileResults in
foobar
.