feat: enable http compression by sending data not with chunked encodi…

[DeepDiver1975]

…ng - if possible

http compression can only be used if chunked encoding is not used.
Therefore if the response body "fits into one chunk" end() is called instead of write() followed by end()

refs: https://openswoole.com/docs/modules/swoole-http-server/configuration#http_compression

Applies to swoole as well

[nunomaduro]

Can you add tests on this please?

[DeepDiver1975]

Can you add tests on this please?

Two tests have been added:

• one to test the chunked behavior
• one to test the not chunked behavior

[taylorotwell]

Has conflicts.

[taylorotwell]

Please mark as ready for review when fixed.

[DeepDiver1975]

@taylorotwell conflict resolved - thx

[DeepDiver1975]

THX @taylorotwell

[alexryall]

This change contains a breaking change for us. Currently we are GZIP encoding responses with the below code and with this change the server returns malformed responses. For now I've locked our Octane version to 1.5.4, what would be the recommended way to GZIP encode responses? I don't want to add an extra layer e.g. Nginx just to encode the response.

<?php

namespace App\Http\Middleware;

use Closure;
use Illuminate\Http\Request;

class GzipEncodeResponse
{
    /**
     * @param Request $request
     * @param Closure $next
     * @return \Illuminate\Http\Response|\Illuminate\Http\JsonResponse
     */
    public function handle(Request $request, Closure $next)
    {
        $response = $next($request);

        if (in_array('gzip', $request->getEncodings()) && function_exists('gzencode')) {
            $response->setContent(gzencode($response->getContent(), 5));
            $response->headers->add([
                'Content-Encoding' => 'gzip',
            ]);
        }

        return $response;
    }
}

[DeepDiver1975]

swoole has built in compression capabilities - see the link in the description of this pr.

as long as compiled with the correct options it will work out of the box and there is no need for extra code

[alexryall]

@DeepDiver1975 thanks for explaining, that makes sense. I did try to get the automatic compression working with the official Swoole docker image (using this one currently) but didn't have any joy so ended up doing it within Laravel. I thought it was probably a combination of http_compression not being set to true within Octane and the way the Docker image has been setup.

[alexryall]

With a bit of messing around managed to get Brotli and Gzip working thanks to this change. You're right about the correct packages (libz/brotli) needing to be installed before Swoole is installed.