[2.x] Fixes "Incorrect header size" #719
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of the time of writing, we have documented that customers should stop their Octane servers using the "octane:stop" command. However, it appears that some customers are sending a SIGTERM signal to the "octane:start" command, as reported in this GitHub issue: #713. Specifically, during local development, people often use the
Control + C
shortcut in their terminals.Although behind the scenes, we do invoke the "octane:stop" command when a
SIGTERM
signal is sent to theStartRoadRunnerCommand
, there is an issue with the fact that "octane:stop" does not wait for the underlying worker to stop completely. As a result, there is a possibility that the worker may attempt to communicate with the master process (like a regular Laravel response with sleep(5)) after the master process has been stopped by theStartRoadRunnerCommand
.When this situation occurs, a
RelayException
exception is thrown from a RoadRunner worker, indicating its failure to communicate with the master process. So, there are two approaches to address this issue: