Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Octane considers that the Swoole table size parameter is the number of rows it can store. But this is not true; calculating the number of rows a table can store is hard as it contains the table header, key size, and conflict proportion. Their wiki page does not explain exactly how it works: https://wiki.swoole.com/#/memory/table?id=__construct.
The current Octane implementation is not working as expected. By trying to insert 1000 rows in the example table provided, which sets 1000 as the table size, Swoole was only able to store 596 rows.
This PR adds a test to check if octane can use all available table rows and sets the table conflict proportion to 1 to ensure that the table has allocated memory to at least the defined row counts.