UrlGenerator Sandbox #896
Merged
UrlGenerator Sandbox #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if this would be a breaking change, especially around the |
|
Well it may depend on where you call it... But if you call it on on middleware where it's recommended it shouldn't have any impact as in theory you will always be setting it... But tbh, i think the potential problems we currently have is probably bigger than the people that may be impacted (which is very minimum i think)... 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we're sending the same instance of URL across all requests, when changing
defaultsorforceRootUrl, the change is happening across all requests...This should also fix #809