Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Add laravel/prompts. #917

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Conversation

xiCO2k
Copy link
Contributor

@xiCO2k xiCO2k commented Jun 21, 2024

This PR utilizes the laravel/prompts to improve mostly the $this->choice and the $this->confirm prompts.

Also change the info, warn and error to use the $this->components version.

Before:

before.mov

After:

after.mov

Cheers

@taylorotwell taylorotwell merged commit d9357b9 into laravel:2.x Jun 21, 2024
12 checks passed
@xiCO2k xiCO2k deleted the feat/add-prompts branch June 21, 2024 16:23
driesvints pushed a commit that referenced this pull request Jun 24, 2024
* feat: Add `laravel/prompts`.

* wip

---------

Co-authored-by: Taylor Otwell <taylor@laravel.com>
@crynobone
Copy link
Member

crynobone commented Jun 26, 2024

@xiCO2k There seem to be a regression based on this PR #918

@xiCO2k
Copy link
Contributor Author

xiCO2k commented Jun 27, 2024

Will take a look on that @crynobone

@driesvints
Copy link
Member

@xiCO2k did you figure this one out? Otherwise it might be best if we revert for now.

@xiCO2k
Copy link
Contributor Author

xiCO2k commented Jun 29, 2024

Hey @driesvints did not had the time to check it, will try to look during the weekend.

Thanks.

@xiCO2k
Copy link
Contributor Author

xiCO2k commented Jul 1, 2024

@driesvints PR #920 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants