Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Switch from getKey() to getAuthIdentifier() to match Laravel core #1134

Merged
merged 3 commits into from
Dec 12, 2019

Conversation

kaptk2
Copy link
Contributor

@kaptk2 kaptk2 commented Dec 5, 2019

Switch from getKey to getAuthIdentifier to better match the core and work better with other 3rd party packages. This pull request closes #1006

@driesvints driesvints changed the title Switch from getKey() to getAuthIdentifier() to match Laravel core [9.x] Switch from getKey() to getAuthIdentifier() to match Laravel core Dec 5, 2019
Copy link
Member

@driesvints driesvints left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay but should definitely be noted in the upgrade guide once we release v9

@taylorotwell taylorotwell merged commit 5db9f58 into laravel:master Dec 12, 2019
@Legion112
Copy link

@driesvints, could you please give any estimate when will be the major release?

@driesvints
Copy link
Member

@Legion112 not at this time sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants