[8.x] Shouldn't the migrations use bigIncrements and indexes on relationships?

[KieronWiltshire]

I was looking through the migrations and saw that some of them seem pretty dated and don't use bigIncrements and indexes on certain possible relationships like the user_id field here.

[driesvints]

Have you tried these changes on all four supported DB drivers? Sqlite, MySQL, PostGres & SQL Srv?

[KieronWiltshire]

@driesvints I have only tested this with MySQL, I was under the assumption that the point behind the Schema interface is that it abstracts the four supported drivers away

[driesvints]

@KieronWiltshire have you checked into how the cascading deletes affect the underlying repository code? I suspect atm the code within Passport itself is currently handling the deletion of related records etc.

[KieronWiltshire]

@driesvints I didn't see the point as I couldn't find any use cases as to where it would be damaging, for example... if a client is deleted, shouldn't access tokens etc be deleted along with? there would be no reason to keep them?

[clemblanco]

Same question for oauth_personal_access_clients.client_id?