Adjust newFactory method visibility #1735
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP: 8.3.4
Laravel Framework: 11.2.0
Laravel Passport: 12.0.2
At command line, attempting to create a client_credentials client from instructions in the documentation results in a PHP Fatal error.
The newFactory() method defined in the trait has a protected visibility, while the method has a public visibility in this class implementing the trait, resulting in a visibility compatibility error. The
as
operator could be used to adjust the method visibility, but this seemed like the better, clearer and more straightforward approach.