Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0] Add ext-json dependency #940

Merged
merged 1 commit into from
Jan 21, 2019
Merged

[7.0] Add ext-json dependency #940

merged 1 commit into from
Jan 21, 2019

Conversation

driesvints
Copy link
Member

Was missing apparently.

@taylorotwell taylorotwell merged commit d11c0cc into laravel:7.0 Jan 21, 2019
@taylorotwell
Copy link
Member

Is it even possible to have PHP 7.1 without the JSON extension? Isn't it built in?

@driesvints driesvints deleted the add-ext-json-to-composer branch January 21, 2019 16:01
@driesvints
Copy link
Member Author

@taylorotwell yes but it's always a good idea to add them as a requirement to your composer.json to know exactly which libraries/extensions your project depends on. In the situations where you have a custom build of PHP this can be a good gotcha for your to know why you can't install a library like Passport. PHPStorm has started throwing warnings if these dependencies aren't added:

https://medium.com/@luis.barros.nobrega/ext-json-is-missing-in-composer-json-what-is-this-700a1fcad966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants