Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default hint for the multiselect prompt #50

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

jessarcher
Copy link
Member

This PR uses the hint feature introduced in #44 to add a default hint to the multiselect prompt, instructing users to use the space bar to select options. I went with the term "space bar" as it is the dominant wording used on Wikipedia.

image

A few people have raised this issue specifically referring to the multi-select prompt used in the Laravel installer, which will be many people's first exposure to Prompts and Laravel. We could just add this hint to the multi-select prompts in the installer, but ultimately it seemed more user-friendly to make it the default. If someone does not want the hint, they would need to pass an empty string to the hint argument.

Fixes #41
Fixes #48

@taylorotwell taylorotwell merged commit e9f5937 into main Aug 16, 2023
4 checks passed
@taylorotwell taylorotwell deleted the multiselect-space-hint branch August 16, 2023 14:11
@shane-smith
Copy link

shane-smith commented Aug 30, 2023

This is great, thank you @jessarcher!

As the author of #41, I agree this solves the problem I ran into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants