[8.x] Use the Config facade instead #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
driesvints
changed the title
|
@taylorotwell @driesvints thank you guys. Would we be able to have these changes within the next release? If so, when will it be? Cheers! |
|
Releases are done on Tuesdays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the use of the
config()helper to retrieve theafter_commitvalue when creating theModelObserver.The reason why we would want to have this change is, we would be able to mock the configuration object when
notextending the application within unit tests.As these changes stand by now, they break all tests that call/create
modelsusing thesearchabletrait when extending the PHPUnit tests case class[PHPUnit\Framework\TestCase].Even though it is known we could use these helpers and we should be extending the framework test case class to work on apps tests, they are not resolved if the Laravel app is not present (in the unit context).
Reference: #440
Thank you.