Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Improvements #94

Merged
merged 5 commits into from
Sep 23, 2024
Merged

CI Improvements #94

merged 5 commits into from
Sep 23, 2024

Conversation

crynobone
Copy link
Member

@crynobone crynobone commented Sep 23, 2024

Ensure GitHub Actions correctly pull in Laravel and PHP versions based on configured matrix.

Previously it doesn't locked the configured version, as example PHP 8.0 on Laravel 8 loads Laravel 9:

CleanShot 2024-09-23 at 16 39 33

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone marked this pull request as ready for review September 23, 2024 08:38
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
- php: 7.4
laravel: [9, 10, 11]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Actions doesn't support providing array to exclude or include which cause the issue.

@taylorotwell taylorotwell merged commit 1dc4a3d into master Sep 23, 2024
15 checks passed
@taylorotwell taylorotwell deleted the ci-patch-3 branch September 23, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants