-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.x] Introduce clean-orphaned-assets
binary
#251
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timacdonald
changed the title
[0.8.x] Introduce clean script
[0.8.x] Introduce Oct 8, 2023
purge-orphaned-assets
script
timacdonald
changed the title
[0.8.x] Introduce
[0.8.x] Introduce Oct 8, 2023
purge-orphaned-assets
scriptpurge-orphaned-assets
binary
timacdonald
commented
Oct 8, 2023
timacdonald
force-pushed
the
clean
branch
2 times, most recently
from
December 14, 2023 03:25
7c16afd
to
88db05b
Compare
timacdonald
changed the title
[0.8.x] Introduce
[1.x] Introduce Dec 14, 2023
purge-orphaned-assets
binarypurge-orphaned-assets
binary
timacdonald
changed the title
[1.x] Introduce
[1.x] Introduce Dec 14, 2023
purge-orphaned-assets
binaryclean-orphaned-assets
binary
@timacdonald Would you recommend running Thanks! |
@francoism90 I would. You should use It is only really useful if you are also using the |
tisnamuliarta
referenced
this pull request
in tisnamuliarta/laravel-shadcn
Mar 11, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [laravel-vite-plugin](https://togithub.com/laravel/vite-plugin) | [`^0.8.0` -> `^1.0.0`](https://renovatebot.com/diffs/npm/laravel-vite-plugin/0.7.8/1.0.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/laravel-vite-plugin/1.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/laravel-vite-plugin/1.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/laravel-vite-plugin/0.7.8/1.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/laravel-vite-plugin/0.7.8/1.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>laravel/vite-plugin (laravel-vite-plugin)</summary> ### [`v1.0.2`](https://togithub.com/laravel/vite-plugin/blob/HEAD/CHANGELOG.md#v102---2024-02-28) [Compare Source](https://togithub.com/laravel/vite-plugin/compare/v1.0.1...v1.0.2) - \[1.x] Fix HMR issue when `resources/lang` directory doesn't exist and a symlink is present in the root directory by [@​jessarcher](https://togithub.com/jessarcher) in [https://github.com/laravel/vite-plugin/pull/285](https://togithub.com/laravel/vite-plugin/pull/285) ### [`v1.0.1`](https://togithub.com/laravel/vite-plugin/blob/HEAD/CHANGELOG.md#v101---2023-12-27) [Compare Source](https://togithub.com/laravel/vite-plugin/compare/v1.0.0...v1.0.1) - \[1.x] Simpler conditional by [@​Jubeki](https://togithub.com/Jubeki) in [https://github.com/laravel/vite-plugin/pull/273](https://togithub.com/laravel/vite-plugin/pull/273) - \[1.x] Account for imported CSS files while cleaning by [@​timacdonald](https://togithub.com/timacdonald) in [https://github.com/laravel/vite-plugin/pull/275](https://togithub.com/laravel/vite-plugin/pull/275) - \[1.x] Fix exit error messages by [@​timacdonald](https://togithub.com/timacdonald) in [https://github.com/laravel/vite-plugin/pull/276](https://togithub.com/laravel/vite-plugin/pull/276) ### [`v1.0.0`](https://togithub.com/laravel/vite-plugin/blob/HEAD/CHANGELOG.md#v100---2023-12-19) [Compare Source](https://togithub.com/laravel/vite-plugin/compare/v0.8.1...v1.0.0) - \[1.0] Drop CJS build and export types first by [@​benmccann](https://togithub.com/benmccann) in [https://github.com/laravel/vite-plugin/pull/235](https://togithub.com/laravel/vite-plugin/pull/235) - \[1.x] Introduce `clean-orphaned-assets` binary by [@​timacdonald](https://togithub.com/timacdonald) in [https://github.com/laravel/vite-plugin/pull/251](https://togithub.com/laravel/vite-plugin/pull/251) - \[0.8.x] Respect vite server.origin in viteDevServerUrl by [@​nurdism](https://togithub.com/nurdism) in [https://github.com/laravel/vite-plugin/pull/255](https://togithub.com/laravel/vite-plugin/pull/255) - \[1.x] Vite 5 by [@​timacdonald](https://togithub.com/timacdonald) in [https://github.com/laravel/vite-plugin/pull/269](https://togithub.com/laravel/vite-plugin/pull/269) - \[0.8.x] Fallback pages by [@​timacdonald](https://togithub.com/timacdonald) in [https://github.com/laravel/vite-plugin/pull/271](https://togithub.com/laravel/vite-plugin/pull/271) - \[1.x] Auto detect Valet / Herd TLS certificates by [@​timacdonald](https://togithub.com/timacdonald) in [https://github.com/laravel/vite-plugin/pull/180](https://togithub.com/laravel/vite-plugin/pull/180) ### [`v0.8.1`](https://togithub.com/laravel/vite-plugin/blob/HEAD/CHANGELOG.md#v081---2023-09-26) [Compare Source](https://togithub.com/laravel/vite-plugin/compare/v0.8.0...v0.8.1) - \[0.8] Fix issue with `0.0.0.0` network resolution by [@​timacdonald](https://togithub.com/timacdonald) in [https://github.com/laravel/vite-plugin/pull/241](https://togithub.com/laravel/vite-plugin/pull/241) - Upgrade vitest by [@​sapphi-red](https://togithub.com/sapphi-red) in [https://github.com/laravel/vite-plugin/pull/246](https://togithub.com/laravel/vite-plugin/pull/246) ### [`v0.8.0`](https://togithub.com/laravel/vite-plugin/blob/HEAD/CHANGELOG.md#v080---2023-08-08) [Compare Source](https://togithub.com/laravel/vite-plugin/compare/v0.7.8...v0.8.0) - fix: compile error following upgrade.md's vite to mix guide by [@​AshboDev](https://togithub.com/AshboDev) in [https://github.com/laravel/vite-plugin/pull/231](https://togithub.com/laravel/vite-plugin/pull/231) - Support Laravel Herd by [@​claudiodekker](https://togithub.com/claudiodekker) in [https://github.com/laravel/vite-plugin/pull/233](https://togithub.com/laravel/vite-plugin/pull/233) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tisnamuliarta/laravel-shadcn). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIzMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
tisnamuliarta
referenced
this pull request
in tisnamuliarta/laravel-shadcn
Mar 22, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [laravel-vite-plugin](https://togithub.com/laravel/vite-plugin) | [`^0.7.5` -> `^1.0.0`](https://renovatebot.com/diffs/npm/laravel-vite-plugin/0.7.8/1.0.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/laravel-vite-plugin/1.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/laravel-vite-plugin/1.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/laravel-vite-plugin/0.7.8/1.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/laravel-vite-plugin/0.7.8/1.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>laravel/vite-plugin (laravel-vite-plugin)</summary> ### [`v1.0.2`](https://togithub.com/laravel/vite-plugin/blob/HEAD/CHANGELOG.md#v102---2024-02-28) [Compare Source](https://togithub.com/laravel/vite-plugin/compare/v1.0.1...v1.0.2) - \[1.x] Fix HMR issue when `resources/lang` directory doesn't exist and a symlink is present in the root directory by [@​jessarcher](https://togithub.com/jessarcher) in [https://github.com/laravel/vite-plugin/pull/285](https://togithub.com/laravel/vite-plugin/pull/285) ### [`v1.0.1`](https://togithub.com/laravel/vite-plugin/blob/HEAD/CHANGELOG.md#v101---2023-12-27) [Compare Source](https://togithub.com/laravel/vite-plugin/compare/v1.0.0...v1.0.1) - \[1.x] Simpler conditional by [@​Jubeki](https://togithub.com/Jubeki) in [https://github.com/laravel/vite-plugin/pull/273](https://togithub.com/laravel/vite-plugin/pull/273) - \[1.x] Account for imported CSS files while cleaning by [@​timacdonald](https://togithub.com/timacdonald) in [https://github.com/laravel/vite-plugin/pull/275](https://togithub.com/laravel/vite-plugin/pull/275) - \[1.x] Fix exit error messages by [@​timacdonald](https://togithub.com/timacdonald) in [https://github.com/laravel/vite-plugin/pull/276](https://togithub.com/laravel/vite-plugin/pull/276) ### [`v1.0.0`](https://togithub.com/laravel/vite-plugin/blob/HEAD/CHANGELOG.md#v100---2023-12-19) [Compare Source](https://togithub.com/laravel/vite-plugin/compare/v0.8.1...v1.0.0) - \[1.0] Drop CJS build and export types first by [@​benmccann](https://togithub.com/benmccann) in [https://github.com/laravel/vite-plugin/pull/235](https://togithub.com/laravel/vite-plugin/pull/235) - \[1.x] Introduce `clean-orphaned-assets` binary by [@​timacdonald](https://togithub.com/timacdonald) in [https://github.com/laravel/vite-plugin/pull/251](https://togithub.com/laravel/vite-plugin/pull/251) - \[0.8.x] Respect vite server.origin in viteDevServerUrl by [@​nurdism](https://togithub.com/nurdism) in [https://github.com/laravel/vite-plugin/pull/255](https://togithub.com/laravel/vite-plugin/pull/255) - \[1.x] Vite 5 by [@​timacdonald](https://togithub.com/timacdonald) in [https://github.com/laravel/vite-plugin/pull/269](https://togithub.com/laravel/vite-plugin/pull/269) - \[0.8.x] Fallback pages by [@​timacdonald](https://togithub.com/timacdonald) in [https://github.com/laravel/vite-plugin/pull/271](https://togithub.com/laravel/vite-plugin/pull/271) - \[1.x] Auto detect Valet / Herd TLS certificates by [@​timacdonald](https://togithub.com/timacdonald) in [https://github.com/laravel/vite-plugin/pull/180](https://togithub.com/laravel/vite-plugin/pull/180) ### [`v0.8.1`](https://togithub.com/laravel/vite-plugin/blob/HEAD/CHANGELOG.md#v081---2023-09-26) [Compare Source](https://togithub.com/laravel/vite-plugin/compare/v0.8.0...v0.8.1) - \[0.8] Fix issue with `0.0.0.0` network resolution by [@​timacdonald](https://togithub.com/timacdonald) in [https://github.com/laravel/vite-plugin/pull/241](https://togithub.com/laravel/vite-plugin/pull/241) - Upgrade vitest by [@​sapphi-red](https://togithub.com/sapphi-red) in [https://github.com/laravel/vite-plugin/pull/246](https://togithub.com/laravel/vite-plugin/pull/246) ### [`v0.8.0`](https://togithub.com/laravel/vite-plugin/blob/HEAD/CHANGELOG.md#v080---2023-08-08) [Compare Source](https://togithub.com/laravel/vite-plugin/compare/v0.7.8...v0.8.0) - fix: compile error following upgrade.md's vite to mix guide by [@​AshboDev](https://togithub.com/AshboDev) in [https://github.com/laravel/vite-plugin/pull/231](https://togithub.com/laravel/vite-plugin/pull/231) - Support Laravel Herd by [@​claudiodekker](https://togithub.com/claudiodekker) in [https://github.com/laravel/vite-plugin/pull/233](https://togithub.com/laravel/vite-plugin/pull/233) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tisnamuliarta/laravel-shadcn). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzguMSIsInVwZGF0ZWRJblZlciI6IjM3LjIzOC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deploying a site and building your assets during a deploy, if you have enough traffic, you can run into issues while building vite assets.
Vite will remove the
manifest.json
and all the existing assets inpublic/build/assets/*
before it writes the new manifest and build assets.This means for a brief time there is no manifest and also in-flight responses will reference assets that no longer exist on the server.
To resolve this you can build your assets and tell Vite not to clean the build directory:
Vite will now write over the manifest and will not remove the existing assets.
This is great, and generally good practice, but it introduces another problem: nothing is cleaning up the old assets. They will continue to grow and overtime these will build up to be a decent size.
This is where the new command comes in. It will read the current manifest and clean out any old build assets that are no longer referenced in the current manifest.
When running this command it is recommend you give a little time after building the new assets before running the command. You need to consider how long a response referencing old assets might take to return to the user and for them to then request the old assets.
General Usage
Clean orphaned assets for non-SSR builds using conventional paths for the manifest and assets.
**Of course I would love this to not be so verbose, but it needs to not conflict with other scripts that may have been configured.
Clean orphaned assets for SSR builds using conventional paths for the manifest and assets.
Flags & Options
--ssr
: Clean SSR assets.--quiet
: No output written.--dry-run
: Does not actually remove the files from the directory.--manifest={path}
: Specify a custom path to the manifest file.--assets={path}
: Specify a custom path to the assets directory.Notes