Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pre-commit hooks and add codespell hook #1244

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

kianmeng
Copy link
Contributor

@kianmeng kianmeng commented Jan 31, 2023

As discussed #1242

@erezsh
Copy link
Member

erezsh commented Jan 31, 2023

Doesn't seem to be working.. I added a comment typo and ran pre-commit run, and codespell passes without any message.

    source_path: Optional[str] # Sxmbol

@kianmeng
Copy link
Contributor Author

kianmeng commented Feb 1, 2023

Unfortunately, codespell don't contains that incorrect typo, Sxmbol in its dictionary file. Maybe because it's not that common, https://github.com/search?q=sxmbol&type=code.

If we change the incorrect typo to:

>> 74     source_path: Optional[str] # Symbo

It worked just fine, as shown:

$ pre-commit run --all-files
...
codespell................................................................Failed
- hook id: codespell
- exit code: 65

lark/lark.py:74: symbo ==> symbol

@erezsh erezsh merged commit da6e7a5 into lark-parser:master Mar 9, 2023
@erezsh
Copy link
Member

erezsh commented Mar 9, 2023

Sorry for the delay. Thanks for contributing!

@kianmeng
Copy link
Contributor Author

🥳 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants