Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump (1.1.7) #1306

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Version bump (1.1.7) #1306

merged 1 commit into from
Jul 20, 2023

Conversation

erezsh
Copy link
Member

@erezsh erezsh commented Jul 20, 2023

Trying the new workflow of making releases as PRs, to address issue #1301, and also give other maintainers and users the opportunity to comment about new releases as they come.

I plan to push this release today, since it's just a bugfix, but next time I will also give a timeline of a week or so ahead.

Open to thoughts and comments about this.

@MegaIng @nat-n

@erezsh erezsh requested a review from MegaIng July 20, 2023 12:40
@erezsh
Copy link
Member Author

erezsh commented Jul 20, 2023

Also, should we be working from a dev branch, and create a PR when we're ready for release, or work from a v1.x.x branch, each time moving to a new one?

@MegaIng
Copy link
Member

MegaIng commented Jul 20, 2023

I think I prefer a dev branch that get's merged into master. v1.x.x style branches would make sense IMO when we are potentially releasing new versions for older subversions (i.e. if we release a bug fix for 1.1 after 1.2 has been released). I don't think this will be that necessary for lark at the moment, so there is no reason to have the infra structure for that.

Copy link
Member

@MegaIng MegaIng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review would make a bit more sense if the change that is in to be released in 1.1.7 wasn't already in master, which I assume will be the case in the future. But anyway, the version bumps looks good :-P

@nat-n
Copy link

nat-n commented Jul 20, 2023

IMO one should release as often as there is something to release :) So it's useful to keep the process lightweight.

There are more sophisticated approaches (like using a release bot to automate releases on every change), but depending on how much you want to emphasize proper collaborative process (vs being God in your own repo) the following lightweight process may be worth considering:

  1. Build up changes on development branch
  2. Manually merge changes to main followed by a version bump commit
  3. Use GitHub releases UI to create a release tag, update the change log, and create a discussion for the release in one step
  4. Merge main back to development (usually just a fast-forward of the version bump commit)

This way the release is a minor chore that a maintainer can do any time, and there's a discussion/announcement created after the fact.

@erezsh erezsh merged commit e795810 into master Jul 20, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants