[#jira] Test changes

larowlan · Jan 21, 2019 · 3ee9742 · 3ee9742
1 parent 5e1bc55
commit 3ee9742
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 44 deletions.
diff --git a/tests/Commands/AliasTest.php b/tests/Commands/AliasTest.php
@@ -15,10 +15,7 @@ class AliasTest extends TlTestBase {
    * @covers ::execute
    */
   public function testCreate() {
-    $this->getMockConnector()->expects($this->any())
-      ->method('ticketDetails')
-      ->with(1234)
-      ->willReturn(new Ticket('Running tests', 123));
+    $this->setupConnector();
     $output = $this->executeCommand('alias', [
       'ticket_id' => 1234,
       'alias' => 'pony',
@@ -35,10 +32,7 @@ public function testCreate() {
    * @covers ::execute
    */
   public function testDelete() {
-    $this->getMockConnector()->expects($this->any())
-      ->method('ticketDetails')
-      ->with(1234)
-      ->willReturn(new Ticket('Running tests', 123));
+    $this->setupConnector();
     $output = $this->executeCommand('alias', [
       'ticket_id' => 1234,
       'alias' => 'pony',
@@ -56,10 +50,7 @@ public function testDelete() {
    * @covers ::execute
    */
   public function testList() {
-    $this->getMockConnector()->expects($this->any())
-      ->method('ticketDetails')
-      ->with(1234)
-      ->willReturn(new Ticket('Running tests', 123));
+    $this->setupConnector();
     $aliases = [
       'some',
       'drunk',

diff --git a/tests/Commands/LogTest.php b/tests/Commands/LogTest.php
@@ -18,10 +18,7 @@ class LogTest extends TlTestBase {
    * @covers ::execute
    */
   public function testLogging() {
-    $this->getMockConnector()->expects($this->any())
-      ->method('ticketDetails')
-      ->with(1234)
-      ->willReturn(new Ticket('Running tests', 123));
+    $this->setupConnector();
     $output = new StreamOutput(fopen('php://memory', 'w', FALSE));
     $command = $this->container->get('app.command.start');
     $command->setApplication($this->application);

diff --git a/tests/Commands/StartTest.php b/tests/Commands/StartTest.php
@@ -33,10 +33,7 @@ public function testStart() {
    * @covers \Larowlan\Tl\Application::doRun
    */
   public function testStartLogging() {
-    $this->getMockConnector()->expects($this->any())
-      ->method('ticketDetails')
-      ->with(1234)
-      ->willReturn(new Ticket('Running tests', 123));
+    $this->setupConnector();
     $output = new StreamOutput(fopen('php://memory', 'w', FALSE));
     $command = $this->container->get('app.command.start');
     $command->setApplication($this->application);
@@ -84,10 +81,7 @@ public function testStopStart() {
    * @covers ::execute
    */
   public function testStartWithComment() {
-    $this->getMockConnector()->expects($this->any())
-      ->method('ticketDetails')
-      ->with(1234)
-      ->willReturn(new Ticket('Running tests', 123));
+    $this->setupConnector();
     $output = $this->executeCommand('start', [
       'issue_number' => 1234,
       'comment' => 'Doing stuff',
@@ -100,10 +94,7 @@ public function testStartWithComment() {
    * @covers ::execute
    */
   public function testAssign() {
-    $this->getMockConnector()->expects($this->any())
-      ->method('ticketDetails')
-      ->with(1234)
-      ->willReturn(new Ticket('Running tests', 123));
+    $this->setupConnector();
     $this->getMockConnector()->expects($this->once())
       ->method('assign')
       ->with(1234)
@@ -121,10 +112,7 @@ public function testAssign() {
    * @covers ::execute
    */
   public function testAssignShortSyntax() {
-    $this->getMockConnector()->expects($this->any())
-      ->method('ticketDetails')
-      ->with(1234)
-      ->willReturn(new Ticket('Running tests', 123));
+    $this->setupConnector();
     $this->getMockConnector()->expects($this->once())
       ->method('assign')
       ->with(1234)
@@ -142,10 +130,7 @@ public function testAssignShortSyntax() {
    * @covers ::execute
    */
   public function testAssignAlreadyAssigned() {
-    $this->getMockConnector()->expects($this->any())
-      ->method('ticketDetails')
-      ->with(1234)
-      ->willReturn(new Ticket('Running tests', 123));
+    $this->setupConnector();
     $this->getMockConnector()->expects($this->once())
       ->method('assign')
       ->with(1234)
@@ -163,10 +148,7 @@ public function testAssignAlreadyAssigned() {
    * @covers ::execute
    */
   public function testStatus() {
-    $this->getMockConnector()->expects($this->any())
-      ->method('ticketDetails')
-      ->with(1234)
-      ->willReturn(new Ticket('Running tests', 123));
+    $this->setupConnector();
     $this->getMockConnector()->expects($this->once())
       ->method('setInProgress')
       ->with(1234)
@@ -261,10 +243,7 @@ public function testStatusAssignAndComment() {
    * @covers ::execute
    */
   public function testStatusAlreadyInProgress() {
-    $this->getMockConnector()->expects($this->any())
-      ->method('ticketDetails')
-      ->with(1234)
-      ->willReturn(new Ticket('Running tests', 123));
+    $this->setupConnector();
     $this->getMockConnector()->expects($this->once())
       ->method('setInProgress')
       ->with(1234)

diff --git a/tests/TlTestBase.php b/tests/TlTestBase.php
@@ -4,6 +4,8 @@
 
 use Larowlan\Tl\Application;
 use Larowlan\Tl\Connector\ConnectorManager;
+use Larowlan\Tl\Tests\Commands\AliasTest;
+use Larowlan\Tl\Ticket;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Config\Definition\Processor;
 use Symfony\Component\Config\FileLocator;
@@ -140,4 +142,17 @@ protected function assertTicketIsOpen($ticket_id, $comment = NULL) {
     return $active;
   }
 
+  /**
+   * Sets up connector.
+   */
+  protected function setupConnector() {
+    $this->getMockConnector()->expects($this->any())
+      ->method('ticketDetails')
+      ->with(1234, 'connector.redmine')
+      ->willReturn(new Ticket('Running tests', 123));
+    $this->getMockConnector()->expects($this->any())
+      ->method('spotConnector')
+      ->willReturn('connector.redmine');
+  }
+
 }