Merge pull request #122 from larowlan/120-visit-alias

[#120] Support aliases in tl visit.
larowlan · Sep 20, 2019 · 4c89932 · 4c89932
2 parents d1cc2e2 + d1e54e5
commit 4c89932
Show file tree

Hide file tree

Showing 3 changed files with 102 additions and 2 deletions.
diff --git a/src/Commands/Visit.php b/src/Commands/Visit.php
@@ -59,6 +59,9 @@ protected function execute(InputInterface $input, OutputInterface $output) {
       $output->writeln('<error>No active ticket, please use tl visit {ticket_id} to specifiy a ticket.</error>');
       return;
     }
+    if ($alias = $this->repository->loadAlias($issue_number)) {
+      $issue_number = $alias;
+    }
     $url = $this->connector->ticketUrl($issue_number, isset($data) ? $data->getConnectorId() : $this->getConnector($input, $output, $issue_number));
     $this->open($url, $output);
   }
@@ -84,7 +87,7 @@ protected function open($url, OutputInterface $output) {
       $browser = 'start';
     }
 
-    if ($browser) {
+    if ($browser && !isset($GLOBALS['__PHPUNIT_BOOTSTRAP'])) {
       shell_exec($browser . ' ' . escapeshellarg($url));
       return;
     }

diff --git a/tests/Commands/AddTest.php b/tests/Commands/AddTest.php
@@ -4,7 +4,6 @@
 
 use Larowlan\Tl\Slot;
 use Larowlan\Tl\Tests\TlTestBase;
-use Larowlan\Tl\Ticket;
 
 /**
  * The test for tl add command.

diff --git a/tests/Commands/VisitTest.php b/tests/Commands/VisitTest.php
@@ -0,0 +1,98 @@
+<?php
+
+namespace Larowlan\Tl\Tests\Commands;
+
+use Larowlan\Tl\Tests\TlTestBase;
+
+/**
+ * The test for tl visit command.
+ *
+ * @coversDefaultClass \Larowlan\Tl\Commands\Visit
+ * @group Commands
+ */
+class VisitTest extends TlTestBase {
+
+  /**
+   * Tests visit command with minimum params.
+   *
+   * @covers ::execute
+   */
+  public function testNoActiveVisit() {
+    $output = $this->executeCommand('visit');
+    $this->assertContains('No active ticket, please use tl visit {ticket_id} to specifiy a ticket.', $output->getDisplay());
+  }
+
+  /**
+   * Tests visit command with active ticket.
+   *
+   * @covers ::execute
+   */
+  public function testActiveVisit() {
+    $this->setupConnector();
+    $this->getMockConnector()->expects($this->once())
+      ->method('ticketUrl')
+      ->with(1234, 'connector.redmine')
+      ->willReturn('https://www.jetbrains.com');
+    $this->executeCommand('start', [
+      'issue_number' => '1234',
+    ]);
+    $this->assertTicketIsOpen(1234);
+    $output = $this->executeCommand('visit');
+    $this->assertContains('Could not find a browser helper.', $output->getDisplay());
+  }
+
+  /**
+   * Tests visit command with issue param.
+   *
+   * @covers ::execute
+   */
+  public function testIssueVisit() {
+    $this->setupConnector();
+    $this->getMockConnector()->expects($this->once())
+      ->method('ticketUrl')
+      ->with(1234, 'connector.redmine')
+      ->willReturn('https://www.jetbrains.com');
+    $output = $this->executeCommand('visit', [
+      'issue' => '1234',
+    ]);
+    $this->assertContains('Could not find a browser helper.', $output->getDisplay());
+  }
+
+  /**
+   * Tests visit command with issue alias param.
+   *
+   * @covers ::execute
+   */
+  public function testAliasVisit() {
+    $this->setupConnector();
+    $this->getMockConnector()->expects($this->once())
+      ->method('ticketUrl')
+      ->with(1234, 'connector.redmine')
+      ->willReturn('https://www.jetbrains.com');
+    $output = $this->executeCommand('alias', [
+      'ticket_id' => 1234,
+      'alias' => 'pony',
+    ]);
+    $this->assertRegExp('/Created new alias/', $output->getDisplay());
+    $output = $this->executeCommand('visit', [
+      'issue' => 'pony',
+    ]);
+    $this->assertContains('Could not find a browser helper.', $output->getDisplay());
+  }
+
+  /**
+   * Tests visit command with invalid issue.
+   *
+   * @covers ::execute
+   */
+  public function testInvalidTicketVisit() {
+    $this->getMockConnector()->expects($this->once())
+      ->method('spotConnector')
+      ->willReturn(FALSE);
+    $this->expectException(\InvalidArgumentException::class);
+    $this->executeCommand('visit', [
+      'issue' => '5678',
+    ]);
+  }
+
+}