Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap gas usage in Before/AfterTx hooks #1

Closed
larry0x opened this issue May 28, 2023 · 0 comments · Fixed by #6
Closed

Cap gas usage in Before/AfterTx hooks #1

larry0x opened this issue May 28, 2023 · 0 comments · Fixed by #6

Comments

@larry0x
Copy link
Owner

larry0x commented May 28, 2023

@sunnya97 pointed out that under the current design, there is a way to attack the chain: do some very heavy computations in the Before/AfterTx hooks, then throw an error to make the tx fail. Since the tx fails, no gas fee will be paid, but the nodes have been put under heavy loads. A solution to this is to have a max gas cap in the sudo contract calls.

tac0turtle pushed a commit to tac0turtle/abstract-account that referenced this issue Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant