Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #202

Merged
merged 3 commits into from
Mar 19, 2021
Merged

Update package.json #202

merged 3 commits into from
Mar 19, 2021

Conversation

harsha509
Copy link
Contributor

Updating xmldom package version

Updating xmldom package version
@larrymyers
Copy link
Owner

@JS31096 for this change to be available on npm the minor version in the package.json must be bumped.

@harsha509
Copy link
Contributor Author

Hi @larrymyers ,

so, will there be any planned minor releases in the future for the changes to be available.

"xmldom": "^0.1.22" is throwing dependabot alerts so made the change.

Please let me know if there can be any release so that I can contribute accordingly and update minor version release to 2.3.3 in package.json

Thanks!

package.json Outdated Show resolved Hide resolved
Co-authored-by: Brandon Duffany <brandonduffany@gmail.com>
@Arjan321
Copy link

Hi @larrymyers , is there a possibility for this to be merged and released? This is currently causing npm audit failures.

@bduffany
Copy link
Contributor

Friendly ping, we have a transitive dep on this package and it's causing a security warning in our repo. Would be great to get this merged in. Anything I can do to help with this? For example, if you're waiting to merge until there's more extensive testing to make sure that this works, I'd be happy to help with that, but would need some pointers on how to go about doing so.

@putermancer
Copy link
Collaborator

No, I think it's mostly that this package is in extreme maintenance mode, and neither of us spends much time on this project these days. So it's a combination of "out of sight, out of mind," and "the squeaky gets the grease."

Thanks for squeaking, and thanks for the update. Merging!

@putermancer putermancer merged commit a0110b7 into larrymyers:master Mar 19, 2021
@putermancer
Copy link
Collaborator

Merged, tagged, published to npm. Have a good day!

@bduffany
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants