DeprecationWarning: The punycode module is deprecated

[Arondight]

(node:2941255) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
    at node:punycode:5:10
    at NativeModule.compileForInternalLoader (node:internal/bootstrap/loaders:312:7)
    at NativeModule.compileForPublicLoader (node:internal/bootstrap/loaders:252:10)
    at loadNativeModule (node:internal/modules/cjs/helpers:49:9)
    at Function.Module._load (node:internal/modules/cjs/loader:804:15)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/opt/apps/Adachi-BOT/node_modules/whatwg-url/lib/url-state-machine.js:2:18)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)

# npm list whatwg-url
adachi-bot@1.5.3 /opt/apps/Adachi-BOT
└─┬ sync-fetch@0.4.1
  └─┬ node-fetch@2.6.7
    └── whatwg-url@5.0.0

jsdom/whatwg-url#191

node-fetch/node-fetch@0959ca9#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L63

@larsgw Will you support node-fetch 3.x (or newer)?

[larsgw]

Will you support node-fetch 3.x (or newer)?

node-fetch 3 introduces a lot of breaking changes, the most problematic one being that the package has been converted to an ES module which makes it impossible to import synchronously.

[larsgw]

But in this case there's not much of a choice, I will see if I can figure something out.

[Arondight]

the package has been converted to an ES module which makes it impossible to import synchronously

This project can also be turned into ESM :)

[larsgw]

I know :) However, I think that a lot of situations in which a synchronous version of fetch is required or useful, will not allow asynchronous import() or import ... from statements.

I see two workarounds:

1. Forking node-fetch. That might cause compatibility problems if both sync-fetch and non-forked node-fetch are used and though I am not sure.
2. In worker.js it's fine to use import() since it is asynchronous anyway. It's imported in index.js to provide basic implementations of Request, Response, Headers, and FetchError (so I only have to implement the sync part, not input parsing etc.). I could copy the parts of these implementations that I need, but that is effectively also a fork, and the sync-fetch implementation might become incompatible with the node-fetch implementation used in worker.js.

[Arondight]

@larsgw You can fork node-fetch 2.x and update whatwg-url, then everything be fine

[Arondight]

That might cause compatibility problems if both sync-fetch and non-forked node-fetch are used and though I am not sure

I don't think so, use @larsgw/node-fetch in your module and node-fetch outside the module so it won't cause problems

[larsgw]

I think I will close this issue in favor of #32 since it is basically about the same thing.

[ashfaque9426]

If you are using windows and still getting this warning after updating to node version 21.1.0 then you need to update the npm itself. type 'npm install -g npm@latest' in cmd and that probably fix your issue. It worked for me.